Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(telemetry): issue with aws sns #1444

Merged
merged 4 commits into from
Mar 6, 2024
Merged

fix(telemetry): issue with aws sns #1444

merged 4 commits into from
Mar 6, 2024

Conversation

iamKunalGupta
Copy link
Member

@iamKunalGupta iamKunalGupta commented Mar 6, 2024 •
edited by serprex
Loading

subject[:100] is byte based, not character based, causing AWS to reject control characters

Properly limit to 100 characters, rather than 100 bytes

@iamKunalGupta iamKunalGupta changed the title fix(telemtry): issue with aws sns fix(telemetry): issue with aws sns Mar 6, 2024
@iamKunalGupta iamKunalGupta requested a review from serprex March 6, 2024 23:24
@iamKunalGupta iamKunalGupta enabled auto-merge (squash) March 6, 2024 23:25
@iamKunalGupta iamKunalGupta merged commit 6b47812 into main Mar 6, 2024
7 checks passed
@iamKunalGupta iamKunalGupta deleted the fix/telemetry/sns-message-subject branch March 6, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex serprex approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamKunalGupta @serprex